Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import configure_inline_support from matplotlib_inline if available #654

Merged
merged 2 commits into from
May 5, 2021

Conversation

ccordoba12
Copy link
Member

This correctly applies the rcParams declared in the inline backend configuration when using "%matplotlib inline".

Pinging @blink1073 about it.

This correctly applies the rcParams declared in the inline backend
configuration when using "%matplotlib inline".
@ccordoba12
Copy link
Member Author

This is failing because it's using jupyter_client 7, which (I think) only works with master. Should I change that to install jupyter_client 6?

@martinRenou
Copy link
Contributor

Thanks for doing this!

This is required because the 5.5.x branch doesn't work with the latest
version
@ccordoba12
Copy link
Member Author

No problem, it took me a couple of hours to figure this one out, but fortunately the fix was quite simple.

@blink1073 blink1073 added this to the 5.5 milestone May 5, 2021
@blink1073 blink1073 added the bug label May 5, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated. Thanks!

@blink1073 blink1073 merged commit fcec32f into ipython:5.5.x May 5, 2021
@ccordoba12 ccordoba12 deleted the fix-matplotlib-inline branch May 5, 2021 16:12
@ccordoba12
Copy link
Member Author

Thanks @blink1073!

@blink1073
Copy link
Contributor

@ccordoba12
Copy link
Member Author

Thanks a lot for your help @blink1073!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants